Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add weekly test-release action #8203

Merged

Conversation

killianmuldoon
Copy link
Contributor

Add a weekly action to ensure the release process is working to regularly check the codebase is in a good-enough state to release.

This would catch issues like #8199 which are release-blocking but may not be known ahead of release time.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2023
@killianmuldoon killianmuldoon force-pushed the pr-release-build-action branch from 4231141 to 368e2c8 Compare March 1, 2023 12:46
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Add weekly test-release action 🌱 Add weekly test-release action Mar 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2023
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on my own branch and locally and it seems to do the job. I don't think we need to run this all that frequently, but open to opinions on that.

@killianmuldoon killianmuldoon force-pushed the pr-release-build-action branch from 368e2c8 to 257144e Compare March 1, 2023 12:47
@killianmuldoon killianmuldoon force-pushed the pr-release-build-action branch from 257144e to 2cf0990 Compare March 1, 2023 13:04
@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor Author

Bleh - looks like a github issue: https://www.githubstatus.com/incidents/bypf7bqdh4g0?utm_ts=1677673199

@sbueringer
Copy link
Member

/lgtm

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 331ace8c4ff41ff8bcd3b400fef5c71b395966ec

@killianmuldoon
Copy link
Contributor Author

/retest

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit a8841fb into kubernetes-sigs:main Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants